Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines output #35

Merged
merged 1 commit into from
Sep 20, 2014
Merged

Lines output #35

merged 1 commit into from
Sep 20, 2014

Conversation

zimbatm
Copy link
Contributor

@zimbatm zimbatm commented Apr 25, 2013

This branch adds the "lines" output format which is quite similar to lograge but also handles structured like arrays and hashes.

The lines format is still a work in progress and I'm looking for input: https://github.com/zimbatm/lines
When adding the lines output you also need to add the "lines" gem in your Gemfile.

Cheers,
zimbatm

@roidrage
Copy link
Owner

I'm afraid for this pull request to be merged, it'll have to be adapted to recent changes in the code, sorry.

@benlovell
Copy link
Collaborator

@zimbatm I'm going to assume this is dead. If you want it merged can you address the outstanding issues. Thanks! ❤️

@zimbatm
Copy link
Contributor Author

zimbatm commented Sep 18, 2014

There 😍

@benlovell
Copy link
Collaborator

Thanks but this has introduced a few issues on travis.

@benlovell
Copy link
Collaborator

@zimbatm Adding lines to the gemfiles for actionpack 3.2 and 4.0 will resolve these issues.

@zimbatm zimbatm force-pushed the lines-output branch 2 times, most recently from 434552c to dfcfad9 Compare September 19, 2014 11:05
@zimbatm
Copy link
Contributor Author

zimbatm commented Sep 19, 2014

thanks, I've missed these additional gemfiles

@benlovell
Copy link
Collaborator

Thanks! 😍 One last thing, would you mind updating the changelog?

@zimbatm
Copy link
Contributor Author

zimbatm commented Sep 19, 2014

done

benlovell pushed a commit that referenced this pull request Sep 20, 2014
@benlovell benlovell merged commit 25bb74d into roidrage:master Sep 20, 2014
@benlovell
Copy link
Collaborator

👍 THANKS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants