You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While I was working on #302, I noticed that the Version field in the database stayed at [0, 578, 0, 5780566] after I ran rbx_reflector, even though my Roblox Studio was on a later version:
{
"Version": [
0,
578,
0,
5780566
],
<truncated>
I discovered that rbx_reflector is grabbing the version from a Roblox endpoint:
Clearly, newer versions of Roblox Studio can ship before this endpoint bumps versions. In any case, there is no guarantee that the local Roblox Studio install is the same version as the one obtained from this endpoint, so rbx_reflector shouldn't do this. Instead, it should probably obtain the version from the injected plugin, like generate_reflection:
While I was working on #302, I noticed that the
Version
field in the database stayed at[0, 578, 0, 5780566]
after I ran rbx_reflector, even though my Roblox Studio was on a later version:I discovered that rbx_reflector is grabbing the version from a Roblox endpoint:
rbx-dom/rbx_reflector/src/studio_version.rs
Line 11 in fd147f7
Right now, it sends me back this:
Clearly, newer versions of Roblox Studio can ship before this endpoint bumps versions. In any case, there is no guarantee that the local Roblox Studio install is the same version as the one obtained from this endpoint, so rbx_reflector shouldn't do this. Instead, it should probably obtain the version from the injected plugin, like generate_reflection:
rbx-dom/generate_reflection/plugin/main.lua
Lines 1 to 13 in fd147f7
This ensures that it always gets the version of the Roblox Studio actually installed on the machine, which is exactly what we want here.
cc @nezuo
The text was updated successfully, but these errors were encountered: