Patch Workspace.CollisionGroups to serialize
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethloeffler
approved these changes
Jul 1, 2023
| } | ||
| } | ||
| }, | ||
| "ReloadLocalPluginsOnChange": { |
There was a problem hiding this comment.
I wonder if this actually works yet 👀
There was a problem hiding this comment.
Stravant had a post on Twitter and in the ROSS server indicating it did. I haven't tested though.
| @@ -57098,7 +57310,7 @@ | |||
| ], | |||
| "Kind": { | |||
| "Canonical": { | |||
| "Serialization": "DoesNotSerialize" | |||
| "Serialization": "Serializes" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302's main issue, where
Workspace.CollisionGroupsno longer serializes. Also updates the database to 582, which includes the changed serialization. Relevant diff is at lines 57299-57316 in the JSON database, if you want to check.There's a lot of deletions in this database update, which made me worried but it appears as though Roblox just actually deleted a bunch of properties. This is unusual but it's not something we really need to worry about.