Fix tooltips crashing on thread cancellation edge cases (#727)

rojo-rbx · Jul 12, 2023 · 28d48a7 · 28d48a7
1 parent 80eb14f
commit 28d48a7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/plugin/src/App/Components/Tooltip.lua b/plugin/src/App/Components/Tooltip.lua
@@ -175,7 +175,7 @@ end
 
 function Trigger:willUnmount()
 	if self.showDelayThread then
-		task.cancel(self.showDelayThread)
+		pcall(task.cancel, self.showDelayThread)
 	end
 	if self.destroy then
 		self.destroy()
@@ -225,7 +225,7 @@ function Trigger:managePopup()
 		end)
 	else
 		if self.showDelayThread then
-			task.cancel(self.showDelayThread)
+			pcall(task.cancel, self.showDelayThread)
 			self.showDelayThread = nil
 		end
 		self.props.context.removeTip(self.id)