Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make plugin warn when syncing in something that isn't a place #113

Closed
LPGhatguy opened this issue Jan 29, 2019 · 4 comments · Fixed by #691
Closed

Make plugin warn when syncing in something that isn't a place #113

LPGhatguy opened this issue Jan 29, 2019 · 4 comments · Fixed by #691
Labels
scope: cli Relevant to the Rojo CLI scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen

Comments

@LPGhatguy
Copy link
Contributor

The plugin tries to destroy the DataModel if you sync in a project that describes a model. That's no good, we should instead catch this case and warn.

Maybe the server should also issue a warning if you serve a non-DataModel project, since that generally doesn't make much sense!
@LPGhatguy LPGhatguy added type: enhancement Feature or improvement that should potentially happen scope: cli Relevant to the Rojo CLI scope: plugin Relevant to the Roblox Studio plugin labels Jan 29, 2019
@masteratminecraftpc2

This comment has been minimized.

Sign in to view
@LPGhatguy LPGhatguy mentioned this issue Jun 29, 2020
Closed
@boatbomber
Copy link
Member

Oh, this issue has gotten more important recently. The diff visualizer for sync confirmation errors when syncing a non-place because it assumes it can access .Parent, which fails a security level check.
image

@boatbomber boatbomber mentioned this issue Jun 2, 2023
Merged
Dekkonot pushed a commit that referenced this issue Jun 30, 2023
@boatbomber
Add protection against syncing non place projects (#691)
66c1cd0 
Closes #113.

Does what it says on the tin. When you try to sync a non-place project,
it gives a clear message instead of crashing.
@steveprogramc

This comment was marked as off-topic.

Sign in to view
@steveprogramc

This comment was marked as off-topic.

Sign in to view
Dekkonot pushed a commit to UpliftGames/rojo that referenced this issue Jan 11, 2024
@boatbomber
Add protection against syncing non place projects (rojo-rbx#691)
ec0f4f4 
Closes rojo-rbx#113.

Does what it says on the tin. When you try to sync a non-place project,
it gives a clear message instead of crashing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: cli Relevant to the Rojo CLI scope: plugin Relevant to the Roblox Studio plugin type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add protection against syncing non place projects boatbomber/rojo
4 participants
@LPGhatguy @boatbomber @masteratminecraftpc2 @steveprogramc