Internal sync loop is recursive w/ promises

[ffrostfall]

The internal syncing loop is implemented recursively, using promises as an abstraction. This is bad because it might be hiding bugs that cause the syncing loop to die without raising any trace, and it generally is not a good way to do syncing.

A better alternative could be a simple non-recursive while loop. This is better for readability, and more straightforward.

Any other alternatives would be appreciated!

[boatbomber]

How would it die without a trace? The purpose of the recursive nature is so that we keep returning a promise that we :catch (line 150 of ServeSession) to ensure we don't miss an error.

[boatbomber]

I'll write a non-recursive version and see if there's any difference. Worst case, the code got a little simpler and easier to understand. Best case, a bunch of weird bugs disappear.

[boatbomber]

I've actually found a likely culprit of the silent death! We use hanging promises in ApiContext to make things just never resolve. If that happens when it shouldn't, there's nothing to :catch and we have silent death. Don't know how to reproduce that, but yeah there's probably some edge case.