Improve Rojo sync reliability #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boatbomber
added
scope: plugin
Dekkonot
approved these changes
Jul 16, 2023
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
Uses non-recursive main loop and avoids hanging promises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #734.
Rojo's main sync loop was a recursive promise method, which may have been obscuring issues. Additionally, ApiContext would choose to silently hang forever where we wanted to silence an error after disconnect, which may have been happening erroneously and causing silent hangs.
I have rewritten these so that ServeSession is non recursive and also knows how to handle ApiContext errors correctly in any state so that the hanging promise solution is no longer needed. Also, it may have not been needed ever since I added promise cancelling to ApiContext, but either way it's certainly not needed now.