Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong version of Rojo displaying in studio. #669

Merged
merged 2 commits into from
May 6, 2023
Merged

Fix wrong version of Rojo displaying in studio. #669

merged 2 commits into from
May 6, 2023

Conversation

Miizzuu
Copy link
Contributor

@Miizzuu Miizzuu commented Apr 28, 2023

Not entirely sure but I looked at some of the code and it seems like this should fix the wrong version showing up, "7.2.1" instead of "7.3.0", hopefully this works...

Copy link
Contributor

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few other files to update:

  • plugin/wally.toml
    ^ and by extension the lock file
  • aftman.toml

Copy link
Contributor

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kampfkarren Kampfkarren changed the title Wrong version of Rojo displaying in studio. Fix wrong version of Rojo displaying in studio. Apr 30, 2023
Copy link
Member

@Kampfkarren Kampfkarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this ought to be in CI, this is too much to change!

@Kampfkarren Kampfkarren enabled auto-merge (squash) April 30, 2023 19:13
@Kampfkarren Kampfkarren merged commit 4b62190 into rojo-rbx:master May 6, 2023
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants