Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync reminder notification & notification actions #689

Merged
merged 16 commits into from
Jul 4, 2023

Conversation

boatbomber
Copy link
Member

@boatbomber boatbomber commented May 31, 2023

Implements and closes #652.

image

image

image

@boatbomber boatbomber added type: enhancement Feature or improvement that should potentially happen scope: plugin Relevant to the Roblox Studio plugin size: medium impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. status: needs review This work is mostly done, but just needs work to integrate and merge it. labels Jun 4, 2023
Copy link
Member

@kennethloeffler kennethloeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition - I'm happy there's a setting to turn it on and off. Can you just edit the PR title to say that it adds notification actions?

I also noticed some perhaps surprising behavior on unpublished Roblox template places (for example, the Baseplate resulting from File>New): DataModel.PlaceId is equal to the original template's before publishing, so if the user has ever synced to an unpublished template, they will get a reminder to sync whenever they create one.

Something similar happens with local place files, which have a DataModel.PlaceId always equal to zero. Not sure what to do about these (maybe just avoid showing the reminder if we're on an unpublished local place file or an unpublished template?), but at the same time, it's probably way more common for the user to want to sync to places that are already published, and they can just turn the reminder off if they're not. Dunno, interested to hear your thoughts here.

@boatbomber boatbomber changed the title Sync reminder notification Sync reminder notification & notification actions Jun 6, 2023
@boatbomber
Copy link
Member Author

Ooh, I honestly forgot those have consistent place ids. I think(?) we can ignorelist them, since the reminder doesn't make sense in their context.

@kennethloeffler
Copy link
Member

I think(?) we can ignorelist them

It's straightforward for local place files, but Roblox could change the template places without warning, and then we'd be right back to spurious notification land. Argh.... well, they don't change very often, do they? Maybe a hard coded check against template place IDs is okay.

@boatbomber
Copy link
Member Author

Fixed it. It was tedious to gather all those place ids initially but it should be literally one liner PRs when they add more.

Copy link
Contributor

@chriscerie chriscerie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, otherwise looks good

plugin/src/App/StatusPages/Settings/Setting.lua Outdated Show resolved Hide resolved
plugin/src/App/Notifications.lua Outdated Show resolved Hide resolved
}),

LogLevel = e(Setting, {
id = "logLevel",
name = "Log Level",
description = "Plugin output verbosity level",
transparency = self.props.transparency,
layoutOrder = 5,
layoutOrder = 100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the layout order for this and the typechecking setting so high? I'm not intimately familiar with the plugin, so forgive me if this is an obvious question.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are dev settings, not really used by consumers, so they're set really high so that they'll always be last in the list and out of the way of users without us having to manually update their layoutorder by one every time we add a setting.

RojoNotifications = e("ScreenGui", {
ZIndexBehavior = Enum.ZIndexBehavior.Sibling,
ResetOnSpawn = false,
DisplayOrder = 100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as with the LayoutOrders; what's the reason this is so large?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rojo Notifications need to display on top for users to see. We don't know what else may be in their CoreGui, so we just use a high display order to increase our odds of having notifications viewable.

Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dekkonot Dekkonot enabled auto-merge (squash) July 4, 2023 20:05
@Dekkonot Dekkonot merged commit 658d211 into rojo-rbx:master Jul 4, 2023
@boatbomber boatbomber deleted the sync-reminder-notification branch July 4, 2023 20:10
Dekkonot added a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
Implements and closes rojo-rbx#652.

---------

Co-authored-by: Chris Chang <[email protected]>
Co-authored-by: Micah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: medium Moderate issue for Rojo users or a large issue with a reasonable workaround. scope: plugin Relevant to the Roblox Studio plugin size: medium status: needs review This work is mostly done, but just needs work to integrate and merge it. type: enhancement Feature or improvement that should potentially happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt to resume syncing when entering place where you previously used Rojo
4 participants