Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rojo open #896

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add rojo open #896

wants to merge 4 commits into from

Conversation

nezuo
Copy link
Contributor

@nezuo nezuo commented Mar 21, 2024

Closes #305.

  • Support existing local places (partially-managed).
  • Potentially support cloud places (except for automatically connecting)
  • Potentially installing the rojo plugin locally
  • Rojo saves previous hosts/ports you've connected to. When we generate a port, we don't want that to be saved.

@nezuo nezuo marked this pull request as draft March 21, 2024 05:00
@nezuo
Copy link
Contributor Author

nezuo commented Mar 21, 2024

My current thoughts on the API:

rojo open <PROJECT_FILE>

Flags:
--output (-o) <PATH>: Builds the place from scratch and output it at <PATH>.
--place (-p) <PATH_OR_CLOUD_PLACE_ID>: Opens an existing place, doesn't build anything from scratch and doesn't skip the initial sync.

--output and --place can't both be specified.

I also want a flag to skip initial sync even with --place. I have projects that are fully managed but part of the build step uses Lune. This means I have existing place files that I can't build from scratch with Rojo but I still want to skip the initial sync. I'm worried that this flag might introduce confusion for users and I don't know what to call it.

Thoughts?

@nezuo
Copy link
Contributor Author

nezuo commented Mar 22, 2024

One flaw with injecting a StringValue is that if the user opens an existing place and doesn't save it, the next time they open it the StringValue will still be there.

Maybe existing places shouldn't automatically connect? That would be really unfortunate.

@Yumacide Yumacide mentioned this pull request Jul 13, 2024
3 tasks
@Yumacide
Copy link

Rojo saves previous hosts/ports you've connected to. When we generate a port, we don't want that to be saved.

It might be better not to randomize the port then. The behavior shouldn't be different from rojo serve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'rojo open' command
2 participants