Check if in TypeExpression before doing VariableExpression checks (#122)

* Check for being in a type expression before doing VariableExpression checks

* Added tests for typecasts

src/plugins/trackCodeFlow/index.spec.ts

@@ -89,6 +89,34 @@ describe('trackCodeFlow', () => {
         expect(actual).deep.equal(expected);
     });
 
+    it('does not mark inline anonymous functions param types as uninitialised vars', async () => {
+        const diagnostics = await linter.run({
+            ...project1,
+            files: ['source/inline-functions.bs'],
+            rules: {
+                'unused-variable': 'error'
+            },
+            diagnosticFilters: []
+        } as any);
+        const actual = fmtDiagnostics(diagnostics);
+        const expected = [];
+        expect(actual).deep.equal(expected);
+    });
+
+    it('does not mark typecasts as uninitialised vars', async () => {
+        const diagnostics = await linter.run({
+            ...project1,
+            files: ['source/typecast-expressions.bs'],
+            rules: {
+                'unused-variable': 'error'
+            },
+            diagnosticFilters: []
+        } as any);
+        const actual = fmtDiagnostics(diagnostics);
+        const expected = [];
+        expect(actual).deep.equal(expected);
+    });
+
     describe('does not mark enums as uninitialised vars', () => {
         it('in a regular file', async () => {
             const diagnostics = await linter.run({

src/plugins/trackCodeFlow/varTracking.ts

@@ -280,7 +280,7 @@ export function createVarLinter(
     }
 
     function visitExpression(expr: Expression, parent: Expression, curr: StatementInfo) {
-        if (isVariableExpression(expr)) {
+        if (isVariableExpression(expr) && !util.isInTypeExpression(expr)) {
             const name = expr.tokens.name.text;
             if (name === 'm') {
                 return;

test/project1/source/inline-functions.bs

@@ -0,0 +1,10 @@
+sub main()
+    takesFunction(function(input as object) as string
+        return "Hello, " + input.name + "!"
+    end function)
+end sub
+
+
+sub takesFunction(anonFunc as function)
+    print anonFunc({name: "Hello, World!"})
+end sub

test/project1/source/typecast-expression.bs

@@ -0,0 +1,14 @@
+typecast m as MyTypeCast
+
+
+
+sub main(input)
+    print m.name
+    print (input as myTypeCast).name
+    print (input as dynamic).name
+end sub
+
+
+interface MyTypeCast
+    name as string
+end interface