Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Brighterscript to v1.0.0-alpha.33 and fixed issues #112

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Updated Brighterscript to v1.0.0-alpha.33 and fixed issues #112

merged 2 commits into from
Jun 20, 2024

Conversation

markwpearce
Copy link
Collaborator

  • Ran npm audit fix
  • Changed all Token.range and AstNode.range references to *.location.range
  • Changed getLeadingTrivia(), getEndTrivia() to use getters

TwitchBronBron
TwitchBronBron approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There's one "unused variable" warning from the build server that needs fixed.

Also, could you run this against one of your projects to see if it works without crashing? Once you've done that, feel free to merge it.

@markwpearce markwpearce merged commit fa34cb8 into v1 Jun 20, 2024
5 checks passed
@markwpearce markwpearce deleted the alpha-33 branch June 20, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markwpearce @TwitchBronBron