add no-print rule to enforce use of logger #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsassph
reviewed
Apr 15, 2021
src/plugins/codeStyle/index.ts
Outdated
| @@ -56,6 +56,11 @@ export default class CodeStyle { | |||
| ); | |||
| } | |||
| } | |||
| }, | |||
| PrintStatement: s => { | |||
| if (noPrint) { | |||
There was a problem hiding this comment.
So I made no-print rules a RulesSeverity and I actually meant to remove this if.
'no-print'?: RuleSeverity;
If you'd rather it be a different type lmk
| noPrint: (range: Range, severity: DiagnosticSeverity) => ({ | ||
| severity: severity, | ||
| code: CodeStyleError.NoPrint, | ||
| message: `${CS} don't use direct Print statements`, |
There was a problem hiding this comment.
While we're doing another round of review, maybe:
"Avoid using direct Print statements"?
|
@slheavner I think you should remove the |
slheavner
force-pushed
the
feature/no-print
branch
from
f24e1ca
to
abcc84f
Compare
slheavner
force-pushed
the
feature/no-print
branch
from
abcc84f
to
6a4d6d7
Compare
|
was wondering why that updated, reverted. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
no-consolerules for eslint/tslint. Enforces the use of a logging framework rather than raw print statements.