Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented newline-last rule #58

Merged
merged 8 commits into from
Apr 13, 2022
Merged

Implemented newline-last rule #58

merged 8 commits into from
Apr 13, 2022

Conversation

arturocuya
Copy link
Contributor

Also considered naming this eol-last like eslint does, but I think "newline" is more undestandable.

philippe-elsass-deltatre
philippe-elsass-deltatre reviewed Mar 29, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
philippe-elsass-deltatre
philippe-elsass-deltatre suggested changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@philippe-elsass-deltatre philippe-elsass-deltatre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice contribution!

@arturocuya arturocuya marked this pull request as draft March 29, 2022 20:17
@arturocuya
Copy link
Contributor Author

@philippe-elsass-deltatre Update:

  • Renamed rule to eol-last
  • Added automatic fix

@arturocuya arturocuya marked this pull request as ready for review April 3, 2022 17:07
elsassph
elsassph reviewed Apr 4, 2022
View reviewed changes
README.md Show resolved Hide resolved
@arturocuya
Copy link
Contributor Author

Update:

  • As Bron suggested, if possible don't assume line ending for fixing. Use the last line ending instead, except when the file is a valid one-liner that needs to be fixed.
  • Cleaned up code for checking if file is empty.
  • Simplified how temp files are created in tests.

@arturocuya
Copy link
Contributor Author

Update: Rebase from master after another PR was merged.

@TwitchBronBron TwitchBronBron merged commit d50fc30 into rokucommunity:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsassph elsassph elsassph left review comments

@philippe-elsass-deltatre philippe-elsass-deltatre philippe-elsass-deltatre requested changes

@TwitchBronBron TwitchBronBron TwitchBronBron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arturocuya @elsassph @TwitchBronBron @philippe-elsass-deltatre