Minor edit

[dcoeurjo]

Hop

[dcoeurjo]

Here you have my issues with Xcode.. weird stuff..

line 222, testVoronoiMap, the IDE wants me to add extra {} around false, false and later complains with the VoronoiMap constructor (not viable constructor).

[dcoeurjo]

BTW, you never use isPeriodic()

Compared to the previous version, there is a slight overhead due to the if (isPeriodic[dim]) tests if I'm right.

[rolanddenis]

By the way, C++ doesn't implicitly declare the default constructor if any other constructor is defined. So deleting it is not mandatory even if it is clearer.

[rolanddenis]

About the error with Xcode, I think it should accept the brace elision but since it is a common pitfall, I propose to add the extra {}:

 bool testVoronoiMap( std::array<bool, 2> const& periodicity = { { false, false } } )

Yes, I designed isPeriodic() for user-interface only but I should used it instead of testing myPeriodicitySpec directly.

I'm agree that the only overhead is on the periodicity tests since I specifically split the loops in generic and periodic parts. It should be negligible, isn't it ?

[dcoeurjo]

Yeah it's negligible.
An alternative would have been to consider a static periodicity map (in template parameters) allowing the compiler to optimize the code (and cut branches) at compile time but it would probably have been less interesting for the user.

[dcoeurjo]

BTW, it was not an error from Xcode, just a warning.. my bad

[rolanddenis]

Yes, I also think about it but since other DGtal classes don't work this way (actually only KhalimskySpaceND 😉 ), it would complicate user life. However, with additional work, it is possible to have a class that works both way (like Eigen with Dynamic magic value).

[rolanddenis]

Can I merge ?

[dcoeurjo]

Yep please. Try to merge the commits without closing my PR (and don't know if the PR will still be open with no diff...).
I'll probably help you to polish the doc according to this new cool feature.

[dcoeurjo]

;) damit, it automatically closes the PR

[rolanddenis]

😄

[dcoeurjo]

ok I 've just pushed a tiny edit and i have to create a new PR so that you can see it...

[rolanddenis]

Ok, next time, I will directly merge from you branch ...

I will also push some documentation updates.

[dcoeurjo]

👌