Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace object type defs with dictionary type #1079

Merged

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Jan 3, 2023

Description of the change

In many places, the type definitions for callback functions use the object type for payload or item arguments. This makes the object opaque and no properties can be accessed in the callback.

This PR updates these to use a generic dictionary type.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes
https://app.shortcut.com/rollbar/story/120642/
#985

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent you an sidechannel note on something here. That said this code is as safe as what it replaces.

@waltjones waltjones merged commit d7e9cbe into master Jan 3, 2023
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
* replace `object` type defs with dictionary type

* prefer unknown over any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants