Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node 8 support #1119

Merged
merged 11 commits into from
Sep 29, 2023
Merged

Remove node 8 support #1119

merged 11 commits into from
Sep 29, 2023

Conversation

mudetroit
Copy link
Contributor

Description of the change

Remove support for node 8, and update dependencies as we are able to.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #127975: Drop Node 8 support to eliminate a security risk.

@mudetroit
chore(deps): update mocha - remaining critical vulnerability
1110e2f
@mudetroit
chore(deps): upgrade webpack
465d317 
This introduces some warnings from older packages that
are no longer maintained. Will revisit them later in
this branch.
@mudetroit
chore(deps): bump karma version
9c062e3
@mudetroit
chore(deps): remove old babel-core (renamed to @babel/core)
c94b60b
@mudetroit
chore(config): remove sourceMap option to terser, has been removed
e56f09b 
If I am reading this correctly it shouldn't be necessary any longer
as it should be respecting the devtool setting
@mudetroit mudetroit force-pushed the matt/sc-127975/remove-node-8-support branch 3 times, most recently from 0adfae0 to e56f09b Compare August 28, 2023 14:10
@mudetroit mudetroit changed the title Rmove node 8 support Remove node 8 support Aug 28, 2023
@mudetroit mudetroit marked this pull request as ready for review August 28, 2023 17:04
@mudetroit
Copy link
Contributor Author

@waltjones we talked about possibly vendorizing istanbul-instrumenter-loader. I haven't done that yet; because, there were about 3 other packages that still flagged vulnerabilities. I didn't know if it was worth it for the single item or not. Totally open to your opinion there.

@waltjones
Copy link
Contributor

I think removing Node 8 clears the way to upgrade to a newer webpack, karma, etc. and then we don't need this package.

That said, I wouldn't be opposed to vendorizing in the short term. Sooner than later we should update the main build/CI deps.

@mudetroit
Copy link
Contributor Author

I think removing Node 8 clears the way to upgrade to a newer webpack, karma, etc. and then we don't need this package.

That said, I wouldn't be opposed to vendorizing in the short term. Sooner than later we should update the main build/CI deps.

@waltjones I would agree, how would you feel about splitting the deprecation of Node 8 support from upgrading webpack/karma/etc? Make this the official break leaving us more free to select what the next step is

@waltjones
Copy link
Contributor

splitting the deprecation of Node 8 support from upgrading webpack/karma/etc

👍 Agreed.

@mudetroit mudetroit merged commit a983381 into master Sep 29, 2023
4 checks passed
@mudetroit mudetroit deleted the matt/sc-127975/remove-node-8-support branch September 29, 2023 14:16
mudetroit added a commit that referenced this pull request Mar 14, 2024
@mudetroit
Merge pull request #1119 from rollbar/matt/sc-127975/remove-node-8-su…
29e1c72 
…pport

Remove node 8 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waltjones waltjones waltjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mudetroit @waltjones