[Refactor] Bundle duplicated replace function
#1128
Merged
+11
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujiyamaorange
changed the title
replace function
matux
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
LGTM, regarding comment:
If either target needs to change it, it can just be split back out again. And as @mudetroit said, there's very little active development in that code path anyway. - @waltjones
Thank you, @fujiyamaorange!
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Bundle duplicated
replacefunction.Type of change
Related issues
I've not create any issues because I met this duplications while I was reading codes.
Checklists
Development
Code review