Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #331 Verbose logging was using the wrong key structure #332

Merged
merged 3 commits into from
Jul 11, 2017

Conversation

rokob
Copy link
Contributor

@rokob rokob commented Jul 6, 2017

The queue gets the item to log that represents the data in the final payload structure of

{
  "access_token": "abc123",
  "data": { ... }
}

rather than the whole payload itself. The API object is responsible for wrapping that data object up
inside a structure like the above and then sending it. Thus the body of the item is a top level key
rather than nested under the data key.

Secondly, everyone wants the original error to be output if there is one isntead of just the
exception message, so make it so.

rokob added 2 commits July 5, 2017 17:47
The queue gets the item to log that represents the data in the final payload structure of
```
{
  "access_token": "abc123",
  "data": { ... }
}
```

rather than the whole payload itself. The API object is responsible for wrapping that data object up
inside a structure like the above and then sending it. Thus the body of the item is a top level key
rather than nested under the data key.

Secondly, everyone wants the original error to be output if there is one isntead of just the
exception message, so make it so.
@rokob
Copy link
Contributor Author

rokob commented Jul 6, 2017

This also fixes #320

@rokob rokob merged commit 800008a into master Jul 11, 2017
@rokob rokob deleted the fix-verbose-logging branch February 1, 2018 23:02
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
Fix #331 Verbose logging was using the wrong key structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant