first pass at a typescript declaration file #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! fyi @TimMensch that this is in progress |
|
Thanks for the update and quick response. :) |
|
I'm going to merge this so there is something and we can iterate on it further if there are any issues. |
Agamnentzar
reviewed
Jul 31, 2017
| export = Rollbar; | ||
|
|
||
| declare class Rollbar { | ||
| constructor(options: Rollbar.Configuration?); |
There was a problem hiding this comment.
should be constructor(options?: Rollbar.Configuration);
|
|
||
| public global(options: Rollbar.Configuration): Rollbar; | ||
| public configure(options: Rollbar.Configuration): Rollbar; | ||
| public lastError(): Error?; |
There was a problem hiding this comment.
should be public lastError(): Error | undefined;
| captureUncaught?: boolean; | ||
| captureUnhandledRejections?: boolean; | ||
| } | ||
| export type Callback = (err: Error?, response: object) => void; |
There was a problem hiding this comment.
should be export type Callback = (err: Error | undefined, response: object) => void;
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
first pass at a typescript declaration file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #302