Address issue with handleItemWithError possible not calling the callback #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d cause odd behaviour
|
I traced all of the code paths through the transforms and parsing errors versus messages. The only thing I can see that could have been causing issues was a certain callback getting called twice which could have caused an issue with the way the indexing is shared in the transforms. Exactly what this would do is not clear, but it is nonetheless wrong and this fixes it. |
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Address issue with handleItemWithError possible not calling the callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix one case where we might have called the callback twice which could cause odd behaviour