Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreDuplicateErrors config flag #755

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Conversation

waltjones
Copy link
Contributor

Rollbar.js discards consecutive identical uncaught errors after sending the first error. This new flag allows overriding that behavior and transmitting all duplicate errors.

@brianr
Copy link
Member

brianr commented Jul 29, 2019

For consideration: would this flag make more sense in reverse? i.e. the feature here is to detect duplicates and then not transmit them. So maybe the flag could be dropDuplicateErrors or ignoreDuplicateErrors, with a default value of true (to maintain current behavior as the default)

@waltjones
Copy link
Contributor Author

@brianr The more I look at it, ignoreDuplicateErrors seems better.

@waltjones waltjones changed the title Add transmitDuplicateErrors config flag Add ignoreDuplicateErrors config flag Jul 30, 2019
@waltjones waltjones merged commit c90c91b into master Jul 31, 2019
mudetroit pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants