Use better message when rollbar.log is called with null or missing arguments #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltjones
force-pushed
the
wj-null-arguments
branch
from
df96eb7
to
efd3349
Compare
1 task
mudetroit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Use better message when rollbar.log is called with null or missing arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a more meaningful message when a Rollbar message is blank. This typically occurs when an argument is intended to be non-null, but is actually null or missing.
The most odd case is when calling something like
Rollbar.error(null)in browser js. The message that shows up in the dashboard is:{"extraArgs":[null]}These cases will now use the message 'Item sent with null or missing arguments.', which should be more helpful to both the user and Rollbar customer support.