Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support capturing code context from sourcesContent in the source map file #959

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

waltjones
Copy link
Contributor

Description of the change

Whether using source maps in Node.js or not, Rollbar.js has long had the ability to get code context (current line of code, plus surrounding lines) from the local source files at runtime.

This PR adds the ability to get this code context from the sourcesContent data in the source map file(s) when:

  • The code is transpiled and has source maps. (For Node, this is usually Typescript.)
  • The transpiled code and source maps are deployed away from the original sources.
  • The source maps were generated with sourcesContent enabled.

Under the above conditions, code context will be captured successfully without access to the original source files.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

ch87007

#957

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link
Contributor

@bxsx bxsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based only on the changes, it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants