Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: comment out Trivy as it was info only and has been failing for rate limits #16

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

MSevey
Copy link
Contributor

@MSevey MSevey commented Nov 8, 2024

Overview

Example failure: https://github.com/rollkit/rollkit/actions/runs/11692820719/job/32563038100?pr=1911

We already applied this change in the celestiaorg.

Main reason for commenting it out is because it is something we would like to re-enable in the future once we have time to figure out the ratelimiting.

Summary by CodeRabbit

  • Chores
    • Disabled the docker-security job, which included Docker image building and vulnerability scanning.
    • Updated job dependencies for the docker-build process to streamline workflow execution.

@MSevey MSevey self-assigned this Nov 8, 2024
Copy link

coderabbitai bot commented Nov 8, 2024

Walkthrough

The changes involve modifications to the GitHub Actions workflow defined in the .github/workflows/reusable_dockerfile_pipeline.yml file. Specifically, the docker-security job has been commented out, disabling its functionality related to Docker image building and vulnerability scanning. As a result, the dependencies for the docker-build job have been updated to remove the docker-security job, while maintaining its dependencies on the prepare-env and logic-check jobs. The overall structure of the workflow remains unchanged.

Changes

File Path Change Summary
.github/workflows/reusable_dockerfile_pipeline.yml Commented out the docker-security job and its steps; updated docker-build job dependencies to remove docker-security.

Sequence Diagram(s)

sequenceDiagram
    participant A as User
    participant B as GitHub Actions
    participant C as Docker Build
    participant D as Security Scan

    A->>B: Trigger Workflow
    B->>C: Prepare Environment
    B->>C: Logic Check
    B->>C: Build Docker Image
    C-->>B: Image Built
Loading

🐇 "In the garden where bunnies play,
The security job has hopped away.
With builds and checks, we still proceed,
Just a little less security need.
Let’s build our dreams, come what may,
In our fluffy world, we’ll find our way!" 🐇

Warning

Tool Failures:

Tool Failure Count:


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3fb2eb2 and 9214ab3.

📒 Files selected for processing (1)
  • .github/workflows/reusable_dockerfile_pipeline.yml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/reusable_dockerfile_pipeline.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MSevey MSevey merged commit d5e0a3b into main Nov 13, 2024
22 of 24 checks passed
@MSevey MSevey deleted the docker-pipeline-cleanup branch November 13, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants