Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Adds in a Deep Subtree #8

Merged
merged 42 commits into from
Nov 10, 2022
Merged

feat: Support Adds in a Deep Subtree #8

merged 42 commits into from
Nov 10, 2022

Commits on Nov 1, 2022

  1. ICS23-style approach for DeepSubTree creation

    @tzdybal @Manav-Aggarwal
    tzdybal authored and Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3b69d3a View commit details
    Browse the repository at this point in the history

  2. Fix deepsubtree, all checks pass

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    f2b2183 View commit details
    Browse the repository at this point in the history

  3. Update documentation for deep subtrees

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    e2e1698 View commit details
    Browse the repository at this point in the history

  4. Fix deepsubtree to accomodate left/right paths both

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3312469 View commit details
    Browse the repository at this point in the history

  5. Refactor test code

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    9b9af93 View commit details
    Browse the repository at this point in the history

  6. Refactor TestDeepSubtreeStepByStep

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    632434e View commit details
    Browse the repository at this point in the history

  7. Address comments

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    cf3e561 View commit details
    Browse the repository at this point in the history

  8. Refactor code

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    9748514 View commit details
    Browse the repository at this point in the history

  9. Disable gocritic and unused

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    97334b4 View commit details
    Browse the repository at this point in the history

  10. Add description

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    865f266 View commit details
    Browse the repository at this point in the history

  11. Refactor code to check err in Set

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    ebabdd1 View commit details
    Browse the repository at this point in the history

  12. Modify traversal conditions to be clearer

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    ce21251 View commit details
    Browse the repository at this point in the history

  13. feat: build deep subtree from ICS23 inclusion proofs (#9) 

    * feat: build deep subtree from ICS23 inclusion proofs

* feat: handle non-existence proofs

* linter: goimports deepsubtree.go

* refactor: addExistenceProofProof -> addExistenceProof

* fix: un-hardcode size of byte array
    @tzdybal @Manav-Aggarwal
    tzdybal authored and Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    321cd58 View commit details
    Browse the repository at this point in the history

  14. Add more comments

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    7faf697 View commit details
    Browse the repository at this point in the history

  15. Refactor ndb.Commit call outside for loop

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    9bbac4d View commit details
    Browse the repository at this point in the history

  16. verify that in the case that dst.root != nil that the root node hash … 

    …matches the provided hash and check dst.root != nil first
    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    ab241f8 View commit details
    Browse the repository at this point in the history

  17. Add strings and use strings.Repeat

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    202bbd4 View commit details
    Browse the repository at this point in the history

  18. Delete addPath and AddPath

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    d29befe View commit details
    Browse the repository at this point in the history

  19. Remove print statements

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    894e7de View commit details
    Browse the repository at this point in the history

  20. Refactor recomputeHash usage 

    Co-authored-by: Matthew Sevey <[email protected]>
    @Manav-Aggarwal @MSevey
    Manav-Aggarwal and MSevey committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    29a46c8 View commit details
    Browse the repository at this point in the history

  21. return err directly 

    Co-authored-by: Matthew Sevey <[email protected]>
    @Manav-Aggarwal @MSevey
    Manav-Aggarwal and MSevey committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    2ba2d36 View commit details
    Browse the repository at this point in the history

  22. Address linting checks

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    a454653 View commit details
    Browse the repository at this point in the history

  23. Use tm-db instead of cosmos-db

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    7cfcfcd View commit details
    Browse the repository at this point in the history

  24. Fix linter

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    b2d8b6b View commit details
    Browse the repository at this point in the history

  25. Add test to check add operation in deepsubtree: WIP

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    269fd08 View commit details
    Browse the repository at this point in the history

  26. Add insert key functionality WIP

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    23c3ee1 View commit details
    Browse the repository at this point in the history

  27. Try replicating non-inclusion proofs

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    777f2b5 View commit details
    Browse the repository at this point in the history

  28. Add sibling nodes to nonExistenceProofs

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8ce7e90 View commit details
    Browse the repository at this point in the history

  29. Refactor test code

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    ef499be View commit details
    Browse the repository at this point in the history

  30. Finish adding add functionality to dst

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    979bc34 View commit details
    Browse the repository at this point in the history

  31. Add Remove functionality to dst

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    b916c9e View commit details
    Browse the repository at this point in the history

  32. Fix linting errors

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    6b20d93 View commit details
    Browse the repository at this point in the history

  33. Fix GetSiblingNode

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    6ecd667 View commit details
    Browse the repository at this point in the history

  34. Remove more print statements

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    b3e0e91 View commit details
    Browse the repository at this point in the history

  35. Add comment for each case in recursive set

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    0808b00 View commit details
    Browse the repository at this point in the history

  36. Change which methods are exported and document exported methods

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    6623985 View commit details
    Browse the repository at this point in the history

  37. feat: Support Empty Hashes and Add constructor (#11) 

    * Export siblings

* Add deepsubtree constructor

* Support empty root hashes

* Use working hash instead of root.hash
    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    b12d7d6 View commit details
    Browse the repository at this point in the history

  38. Use tm-db instead of cosmos-db

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    98568c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge branch 'deepsubtrees' into manva/add_add_and_delete

    @Manav-Aggarwal
    Manav-Aggarwal authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    a068e86 View commit details
    Browse the repository at this point in the history

  2. Return nil in BuildTree

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    376feb5 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Address comments

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    510010a View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Address more comments

    @Manav-Aggarwal
    Manav-Aggarwal committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e0630ac View commit details
    Browse the repository at this point in the history