Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commonjs): Restore support for Node 10 after #1038 #1219

Closed
wants to merge 1 commit into from

Conversation

niklasf
Copy link

@niklasf niklasf commented Jul 5, 2022

Rollup Plugin Name: commonjs

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

#1038 raised the required Node version of the commonjs plugin from 8 to 12, mentioning:

  • minimum Node version raised to 12. This allows us to use "async await" (though 10 would have been enough for that...)

Since rollup itself is still usable with Node 10, it makes some sense to stick with 10 as long as reasonably convenient.

@niklasf niklasf requested a review from shellscape as a code owner July 5, 2022 15:11
@shellscape
Copy link
Collaborator

Thanks for the PR, unfortunately our support policy is dictated by the Node LTS policy, which can be viewed here: https://nodejs.org/en/about/releases/

Rollup supporting v10+ is likely an oversight, since v10 dropped out of LTS a very long time ago.

@shellscape shellscape closed this Jul 5, 2022
@lukastaegert
Copy link
Member

We are actively preparing Rollup v3 now, that raises the bar to Node 14 anyway

@niklasf
Copy link
Author

niklasf commented Jul 5, 2022

Fair enough. Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants