-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node-resolve): pass original importee to secondary resolve #1557
Conversation
Thanks for the PR. Could you please provide a much more detailed explanation on what this PR is adding, solving, or fixing for you, with examples? |
@shellscape We want to build plugins as part of our dev tools to offer module analytics and stats. One use case is exploring a different approach to implementing module federation on rollup. For that, at our plugin, we need two pieces of information:
Having the information in 1 and 2 above at the same time in a plugin is crucial to implement some of the tooling aspect we are exploring. So the changes in this PR updates node-resolve to pass them both to further plugins as it does its second resolve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and might indeed be useful. The only thing I hope is that we can use this chance to document this feature (and the "resolved" feature) in the Readme so that people know about it, can you do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, looks good!
Rollup Plugin Name:
node-resolve
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
pass on original
importee
to other plugins.