Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasm): include/exclude options #1558

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

sky0014
Copy link
Contributor

@sky0014 sky0014 commented Aug 11, 2023

Rollup Plugin Name: {@rollup/plugin-wasm}

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

The mainly include/exclude handle code is from @rollup/pluginutils like the other plugin does, It's already been tested yet.

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

@rollup/plugin-wasm missed the common include/exclude options, this PR added this part.

@shellscape
Copy link
Collaborator

Thanks for the PR. CI is failing because while you added a new dependency, you hadn't run pnpm install and so the lockfile was never updated. Please do that and commit the lockfile.

A test for include/exclude would be welcome, but since most of the plugins don't test that, it's not required.

@sky0014
Copy link
Contributor Author

sky0014 commented Aug 14, 2023

Hi @shellscape , just updated lock file and README, welcome to review~

BTW: Taking a global perspective, maybe it's better to move these common options to the rollup plugin base other than implement it in every plugin itself.

@sky0014 sky0014 force-pushed the wasm_include_exclude branch 2 times, most recently from ee08274 to d54c0a2 Compare August 14, 2023 09:21
@luttoo luttoo mentioned this pull request Aug 17, 2023
4 tasks
@sky0014
Copy link
Contributor Author

sky0014 commented Aug 21, 2023

Hi @shellscape , no message for several days, is there still some problem?

packages/wasm/README.md Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
packages/wasm/types/index.d.ts Outdated Show resolved Hide resolved
@sky0014
Copy link
Contributor Author

sky0014 commented Aug 30, 2023

Just updated the PR, take a look when you have time @shellscape

@shellscape
Copy link
Collaborator

@sky0014 looks good now, thanks. please update your branch from upstream so we can run the latest CI

@sky0014
Copy link
Contributor Author

sky0014 commented Sep 14, 2023

@sky0014 looks good now, thanks. please update your branch from upstream so we can run the latest CI

Done.

@tada5hi tada5hi changed the title Add include/exclude options for wasm plugin. feat(wasm): include/exclude options Sep 14, 2023
@shellscape shellscape merged commit a683315 into rollup:master Sep 25, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants