Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allows to develop on Windows #1559

Closed
wants to merge 1 commit into from

Conversation

liuxingbaoyu
Copy link

@liuxingbaoyu liuxingbaoyu commented Aug 12, 2023

Rollup Plugin Name: *

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Allows repo to be developed across platforms.
Ref: #1530 (comment)

@shellscape
Copy link
Collaborator

Thanks for opening a PR. As with most large changes like this, it's best to discuss with the team here first. Unfortunately, we're not going to be able to accept this PR. Windows users are encouraged to use WSL to keep in line with our chosen tooling.

@shellscape shellscape closed this Aug 12, 2023
@liuxingbaoyu
Copy link
Author

From what I understand @lukastaegert seems to have accepted such a change at #1530 (comment)?

Unfortunately WSL does not currently work on my computer, so I can only develop in this way.

@shellscape
Copy link
Collaborator

That is unfortunate.

One of the things you're changing throughout the repository is making our symlinked tsconfig.json files into actual copies. That's not the way this repo is setup (nor is it the way I setup any monorepo that I manage). Your machine not supporting symlinks indicates a deeper issue.

At this time I'm not willing to completely change the dynamic for how the plugins in the workspace interact the processes we've had in place for years. We've had many users contribute that use Windows. I'm sorry that WSL doesn't work on your computer, I would recommend solving that first.

@liuxingbaoyu
Copy link
Author

Your machine not supporting symlinks indicates a deeper issue.

I'm not sure if this is something Windows doesn't support, others have mentioned this.
#1538 (comment)

At this time I'm not willing to completely change the dynamic for how the plugins in the workspace interact the processes we've had in place for years. We've had many users contribute that use Windows. I'm sorry that WSL doesn't work on your computer, I would recommend solving that first.

Thanks for your reply, I see.

@lukastaegert
Copy link
Member

From what I understand @lukastaegert seems to have accepted such a change at #1530 (comment)?

I am sorry I made it seem that way, I should have said that for tooling questions in this repo, @shellscape is the final instance to consult as he set things up and maintains them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants