Update dependencies #513

lukastaegert · 2020-07-28T09:34:23Z

Rollup Plugin Name: `*`

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

This updates all dependencies for all plugins, using one commit per plugin. At the moment, there are some security issues that prevent PRs from passing CI.

lukastaegert · 2020-07-28T09:51:00Z

.eslintrc.js

-        plugins: ['prettier-plugin-package']
-      }
-    ]
+    'prettier/prettier': 'error'


I have moved prettier config to a dedicated file that is shared in all places and provides better IDE support. Relevant change is probably that the printWidth in README files is now 100 characters as well. If this is not desired, I can add an override for markdown files to set it to 80 again.

Yeah please do revert this. This configuration keeps prettier and ESLint from fighting, and requires only a single editor extension. There's a lot of debate about this, but reverting this change is going to cause more trouble than it's worth.

And if we just double the config from the .prettierrc file in the .eslintrc.js file? In any case, I would really love to get rid of the manual prettier --print-width params in favour of central config. As the eslintrc is central as well, that would be fine with me.

lukastaegert · 2020-07-28T09:51:22Z

packages/alias/rollup.config.js

@@ -6,8 +6,8 @@ export default {
  input: 'src/index.ts',
  external: [...Object.keys(pkg.dependencies), 'os'],
  output: [
-    { file: pkg.main, format: 'cjs' },
+    { file: pkg.main, format: 'cjs', exports: 'auto' },


These changes are to silence a warning in latest Rollup.

lukastaegert · 2020-07-28T09:52:05Z

packages/alias/rollup.config.js

    { file: pkg.module, format: 'es' }
  ],
-  plugins: [typescript()]
+  plugins: [typescript({ sourceMap: false })]


Apparently the TypeScript plugin complains if I do not generate a sourcemap unless this is set to false. I assume this will also improve performance.

lukastaegert · 2020-07-28T09:53:01Z

packages/auto-install/package.json

  "scripts": {
    "build": "rollup -c",
    "ci:coverage": "nyc pnpm run test && nyc report --reporter=text-lcov > coverage.lcov",
    "ci:lint": "pnpm run build && pnpm run lint",
    "ci:lint:commits": "commitlint --from=${CIRCLE_BRANCH} --to=${CIRCLE_SHA1}",
    "ci:test": "pnpm run test -- --verbose",
    "lint": "pnpm run lint:js && pnpm run lint:docs && pnpm run lint:package",
-    "lint:docs": "prettier --single-quote --write README.md",


These options are now handled via the .prettierrc file

lukastaegert · 2020-07-28T14:50:06Z

This is now ready for review

shellscape · 2020-07-29T00:12:31Z

@lukastaegert I'll take a look at this tomorrow, was out in the Gulf of Mexico all day today and I'm whooped. Thanks for doing this.

lukastaegert · 2020-07-29T03:49:16Z

Sure, no problem, I envy you! There are some changes I made that you should think about if it is ok, mainly the prettier change. On the other hand, I do not think there is a need to release new versions of any plugins just because of this.

shellscape

Definitely want to revert the prettier changes.

Some additional comments that are probably OK but need some explanation or reply.

I really want to double check that none of the build config updates are going to change functionality of the shipped package. We also need to assert that none of the updates to node-resolve are going to cause downstream issues. Hoping our tests are comprehensive enough, but please do give a second look and a 👍 if you're confident.

shellscape · 2020-07-29T15:15:48Z

.eslintignore

@@ -1 +1 @@
-!.eslintrc.js
+.eslintrc.js


any reason this was changed? we'd like ESLint to ensure that the config file matches style as well.

It was getting a "Parsing error: 'parserOptions.project' has been set to @typescript-eslint-parser'. The file does not match your project config: .eslintrc.js.
The file must be included in at least one of the projects provided."
If you have an idea to make it work, I have not.

shellscape · 2020-07-29T15:17:25Z

.eslintrc.js

-        plugins: ['prettier-plugin-package']
-      }
-    ]
+    'prettier/prettier': 'error'


Yeah please do revert this. This configuration keeps prettier and ESLint from fighting, and requires only a single editor extension. There's a lot of debate about this, but reverting this change is going to cause more trouble than it's worth.

packages/auto-install/rollup.config.js

packages/beep/package.json

packages/dynamic-import-vars/rollup.config.js

shellscape · 2020-07-29T15:25:28Z

packages/yaml/rollup.config.js

 import pkg from './package.json';

 export default {
  input: 'src/index.js',
-  plugins: [


what's the reason for removing the babel plugin?

As we now have a Node 10 baseline, I do not think it makes sense to explicitly transpile down to loader compatibility targets as it both bloats files and makes them less readable. You may have hit an important point here, though: Technically, this would make this a breaking change as we would lift the compatibility baseline to Node 10. I would still love to keep this change but add a "BREAKING CHANGE" note to the commits if you agree. No need to release a new versions right away, though, IMO.

Please feel free to update the engine to v10 in package.json on a new commit for the plugin (and any others that were changed with this) as a breaking change. Totally worth a major, and we've been kicking the can down the road on doing that.

I added the engines property into the original commits and added them as breaking changes to the commit messages

packages/pluginutils/package.json

lukastaegert · 2020-07-29T18:56:51Z

Definitely want to revert the prettier changes.

There is more to it than just reverting because some changes need to be done. Basically what prettier 2 does is it changes a few defaults that do not fit our current code-style. If we do not want a .prettierrc file, then we need to amend each call to the prettier CLI in every single package.json file with a --trailing-comma none and possibly an option for --arrow-parens as well, making this less and less maintainable.

Also it does not use a chance we have with the mono-repo to enforce consistent styling with shared configuration that is easily updated in a central place.

I added another commit to show-case that this is also very flexible by enforcing the previous print width of 80 for README files only. I can of course merge this into the previous commits again, this is just for demonstration:

{
  "arrowParens": "always",
  "printWidth": 100,
  "singleQuote": true,
  "trailingComma": "none",
  "plugins": ["prettier-plugin-package"],
  "overrides": [
    {
      "files": "README.md",
      "options": {
        "arrowParens": "avoid",
        "printWidth": 80
      }
    }
  ]
}

This will also be picked up by ESLint but also has better tooling support so that you can have e.g. prettier on save instead of having to trigger eslint manually time and again. While I agree this is strictly not necessary, I would urge you to use this chance since I needed to touch everything anyway to reduce maintenance overhead here and improve consistency.

.prettierrc

shellscape · 2020-07-29T19:05:10Z

prettier on save instead of having to trigger eslint manually time and again

That's the part that confuses me. Atom, VSCode, VIM, and other editors all have an ESLint plugin that will run automatically. It negates the need for running prettier independently - and it honestly cleans up the conflicts between ESLint and prettier rather well. Prior to merging the two, they were constantly at odds. That's why we went that direction. I recently introduced the same change at work and we've got ~50 devs working the same way daily, with a big improvement in DX. There are different schools of thought on this, but I'd really encourage not trying to change the status quo that we've been operating on in the plugins repo for a good while.

If Prettier@2 is the source of the problem, then is there a compelling reason to update that?

In the mean time, I'll take a look at Prettier@2 and see what's up with the markdown files.

lukastaegert · 2020-07-29T19:13:45Z

No really, it was just two relevant defaults that are different. I can add the flags to the manual calls in the package.json files.

shellscape · 2020-07-29T19:15:57Z

Gotcha. Before you do that, please give me a bit to see if there's another way to go about that. I have an idea I need to test.

lukastaegert · 2020-07-30T04:19:02Z

Ok, then I will not do that yet. Thanks for giving a little more background about why it was handled that way.

BREAKING CHANGES: now requires at least Node 10

lukastaegert · 2020-07-31T04:05:04Z

I did revert the prettiert changes now, in the end it was really only one additional parameter. I hope this can be merged now. Only open point is the eslintignore that is still excluded due to issues with the typescript parser.

shellscape · 2020-07-31T04:41:43Z

Sorry for the delay. I'm on the tail end of a 15 hour day today and I'm wiped. You aren't forgotten I promise!

lukastaegert · 2020-07-31T05:28:45Z

No worries.

lukastaegert force-pushed the update-dependencies branch 2 times, most recently from 7f3fa66 to 6f44561 Compare July 28, 2020 09:47

lukastaegert commented Jul 28, 2020

View reviewed changes

lukastaegert force-pushed the update-dependencies branch 4 times, most recently from f48e3e0 to 5b2a9e7 Compare July 28, 2020 14:24

lukastaegert marked this pull request as ready for review July 28, 2020 14:24

shellscape requested changes Jul 29, 2020

View reviewed changes

shellscape reviewed Jul 29, 2020

View reviewed changes

.prettierrc Outdated Show resolved Hide resolved

lukastaegert force-pushed the update-dependencies branch 2 times, most recently from 9feccb6 to efcf371 Compare July 30, 2020 05:19

lukastaegert added 10 commits July 30, 2020 21:33

chore(alias): update dependencies

b3b8efd

chore(auto-install): update dependencies

adb97d0

chore(babel): update dependencies

13526d6

chore(beep): update dependencies

a4c2e7a

chore(buble): update dependencies

92d6c82

chore(commonjs): update dependencies

fe399e2

chore(data-uri): update dependencies

62c3bf9

chore(dsv): update dependencies

0b25eab

chore(dynamic-import-vars): update dependencies

26f9b6c

chore(html): update dependencies

6c8614c

lukastaegert added 16 commits July 31, 2020 05:46

chore(image): update dependencies

0c57b08

chore(inject): update dependencies

c1a0b07

chore(json): update dependencies

678125b

chore(legacy): update dependencies

5a2e4de

chore(multi-entry): update dependencies

afd93a3

BREAKING CHANGES: now requires at least Node 10

chore(node-resolve): update dependencies

e632469

BREAKING CHANGES: now requires at least Node 10

chore(pluginutils): update dependencies

9f56d37

chore(replace): update dependencies

53e2b73

chore(run): update dependencies

4428bff

chore(strip): update dependencies

7ff3d0c

chore(sucrase): update dependencies

5f07d35

chore(typescript): update dependencies

9e52818

chore(url): update dependencies

1c971a5

BREAKING CHANGES: now requires at least Node 10

chore(virtual): update dependencies

236d7f1

chore(wasm): update dependencies

8ac8237

chore(yaml): update dependencies

943f528

BREAKING CHANGES: now requires at least Node 10

lukastaegert force-pushed the update-dependencies branch from efcf371 to 943f528 Compare July 31, 2020 04:03

shellscape approved these changes Jul 31, 2020

View reviewed changes

shellscape merged commit 4c65d01 into master Jul 31, 2020

shellscape deleted the update-dependencies branch July 31, 2020 13:09

aminya mentioned this pull request Jul 31, 2020

Fix using colon in the filename on Windows #506

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies #513

Update dependencies #513

lukastaegert commented Jul 28, 2020 •

edited

Loading

lukastaegert Jul 28, 2020

shellscape Jul 29, 2020

lukastaegert Jul 29, 2020

lukastaegert Jul 28, 2020

lukastaegert Jul 28, 2020

lukastaegert Jul 28, 2020

lukastaegert commented Jul 28, 2020

shellscape commented Jul 29, 2020

lukastaegert commented Jul 29, 2020

shellscape left a comment

shellscape Jul 29, 2020

lukastaegert Jul 30, 2020

shellscape Jul 29, 2020

shellscape Jul 29, 2020

lukastaegert Jul 29, 2020

shellscape Jul 29, 2020

lukastaegert Jul 30, 2020

lukastaegert commented Jul 29, 2020

shellscape commented Jul 29, 2020

lukastaegert commented Jul 29, 2020

shellscape commented Jul 29, 2020

lukastaegert commented Jul 30, 2020

lukastaegert commented Jul 31, 2020

shellscape commented Jul 31, 2020

lukastaegert commented Jul 31, 2020

		@@ -1 +1 @@
		!.eslintrc.js
		.eslintrc.js

Update dependencies #513

Update dependencies #513

Conversation

lukastaegert commented Jul 28, 2020 • edited Loading

Rollup Plugin Name: *

Description

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukastaegert commented Jul 28, 2020

shellscape commented Jul 29, 2020

lukastaegert commented Jul 29, 2020

shellscape left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukastaegert commented Jul 29, 2020

shellscape commented Jul 29, 2020

lukastaegert commented Jul 29, 2020

shellscape commented Jul 29, 2020

lukastaegert commented Jul 30, 2020

lukastaegert commented Jul 31, 2020

shellscape commented Jul 31, 2020

lukastaegert commented Jul 31, 2020

lukastaegert commented Jul 28, 2020 •

edited

Loading

Rollup Plugin Name: `*`