This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 126
false positives for commonjs check #53
Comments
ref #38 |
yeah this may be a false positive on my part here |
calvinmetcalf
added a commit
to calvinmetcalf/rollup-plugin-commonjs
that referenced
this issue
Mar 14, 2016
wait no, there are certain things that will trigger a wrap including typeof foo checks and (ironically) the global check that uses global only if it's present |
calvinmetcalf
added a commit
to calvinmetcalf/rollup-plugin-commonjs
that referenced
this issue
Mar 15, 2016
calvinmetcalf
added a commit
to calvinmetcalf/rollup-plugin-commonjs
that referenced
this issue
Mar 17, 2016
Just doing some housekeeping – is this still a live issue or can it be closed? |
This was opened on like v3 so I'll reopen if it's still an issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
currently any mention of
require
,module
andexports
causes a module to be flagged as commonjs and in need of transpiling even if it's something likevar a=typeof require=="function"&&require;
(which is part of browserify bundles). Might make sense to do a second, more in depth parse of the files to make sure it really is one.The text was updated successfully, but these errors were encountered: