Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sndcpy apk not found error #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

KptnKMan
Copy link

Created this PR to fix iss in issue:
#80

This should fix apk not found errors in both Windows and Linux when not running the script directly in its own directory.

@rom1v
Copy link
Owner

rom1v commented Nov 20, 2020

Thank you 👍

Will check that soon (hopefully).

@alSku
Copy link

alSku commented Nov 21, 2020

Hey @KptnKMan,
I think while you're at it you should escape the paths too to account for spaces.
Also, I am not sure %~dp0\sndcpy.apk will work, since it would return c:\some\path\\sndcpy.apk

@KptnKMan
Copy link
Author

The point is it to return the path to the script dir, so yes, that's EXACTLY the point.

I've tested it and it works.

@alSku
Copy link

alSku commented Nov 22, 2020

Ye, I wasn't sure about the double back slash. I tested it by now too and it works.
But if the path to the apk contains a space it won't.

@KptnKMan
Copy link
Author

KptnKMan commented Nov 22, 2020

If you have a suggestion, do a code review on the PR, and suggest the code edits to be made.
Thanks.

Copy link

@alSku alSku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support paths with spaces:

SNDCPY_PATH=$(dirname "$SNDCPY_SCRIPT")

@fredaoviana
Copy link

fredaoviana commented Nov 27, 2020

Hi Romain, I could not find another way to contact you...
I am very happy with your app scrcpy. Works great for me.
I wonder if it would be possible to trigger the desktop mode of my cellphone (like when connected to another monitor) using adb or a scrcpy command?
tks

@KptnKMan
Copy link
Author

Hi Romain, I could not find another way to contact you...
I am very happy with your app scrcpy. Works great for me.
I wonder if it would be possible to trigger the desktop mode of my cellphone (like when connected to another monitor) using adb or a scrcpy command?
tks

@fredaoviana
Open an issue if you have an issue.
Don't hijack a PR with off-topic questions please.

@KptnKMan
Copy link
Author

@alSku I can't see your suggestions on the PR.
Not sure why its not showing up.

@alSku
Copy link

alSku commented Dec 4, 2020

Hm maybe I did something wrong
I'm not that well versed in GitHub with what goes beyond the scope of my own repos.
The only thing I added were double quotes in line 6 around $SNDCPY_SCRIPT in the bash script.

@intoyG
Copy link

intoyG commented Mar 28, 2021

can someone teach mo how to enable sounds using sndcpy? got the same error and I do not know how to use codes or something. I just followed all the videos on youtube how to install scrcpy, sndcpy and vlc. same locations and added the sndcpy to my android phone. still got an error of --

adb: failed to stat sndcpy.apk: No such file or directory
Uninstalling existing version first...
Failure [DELETE_FAILED_INTERNAL_ERROR]
Failed with error #1.
Press any key to continue . . . (after pressing continue it closed). nee help. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants