Merge branch 'refactor/comments' into refactor/comments-formatting

rome · Sep 20, 2022 · e546273 · e546273
2 parents d8664ea + 0f746fc
commit e546273
Show file tree

Hide file tree

Showing 119 changed files with 7,903 additions and 867 deletions.
diff --git a/.cargo/config.toml b/.cargo/config.toml
@@ -27,6 +27,7 @@ bench_analyzer = "run -p xtask_bench --release -- --feature analyzer"
 coverage = "run -p xtask_coverage --profile=release-with-debug --"
 rome-cli = "run -p rome_cli --release --"
 rome-cli-dev = "run -p rome_cli --"
+contributors = "run -p xtask_contributors --"
 
 [profile.release]
 lto = true
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -9,6 +9,7 @@ members = [
 	"xtask/coverage",
 	"xtask/lintdoc",
 	"xtask/libs_bench",
+	"xtask/contributors",
 ]
 
 [profile.release-with-debug]

diff --git a/crates/rome_formatter/src/comments.rs b/crates/rome_formatter/src/comments.rs
@@ -365,7 +365,7 @@ impl<L: Language> DecoratedComment<L> {
         self.following.take()
     }
 
-    /// The number of lines between this comment and the **previous** token or comment.
+    /// The number of line breaks between this comment and the **previous** token or comment.
     ///
     /// # Examples
     ///

diff --git a/crates/rome_js_analyze/src/analyzers/correctness.rs b/crates/rome_js_analyze/src/analyzers/correctness.rs
diff --git a/crates/rome_js_analyze/src/analyzers/nursery.rs b/crates/rome_js_analyze/src/analyzers/nursery.rs
diff --git a/...alyzers/correctness/use_optional_chain.rs → ...c/analyzers/nursery/use_optional_chain.rs b/...alyzers/correctness/use_optional_chain.rs → ...c/analyzers/nursery/use_optional_chain.rs
@@ -76,7 +76,7 @@ declare_rule! {
     pub(crate) UseOptionalChain {
         version: "0.10.0",
         name: "useOptionalChain",
-        recommended: true,
+        recommended: false,
     }
 }
 

diff --git a/...seOptionalChain/complexLogicalAndCases.ts → ...seOptionalChain/complexLogicalAndCases.ts b/...seOptionalChain/complexLogicalAndCases.ts → ...seOptionalChain/complexLogicalAndCases.ts
diff --git a/...ionalChain/complexLogicalAndCases.ts.snap → ...ionalChain/complexLogicalAndCases.ts.snap b/...ionalChain/complexLogicalAndCases.ts.snap → ...ionalChain/complexLogicalAndCases.ts.snap
@@ -13,7 +13,7 @@ foo && foo[typeof bar] && foo[typeof bar].baz;
 
 # Diagnostics
 ```
-warning[correctness/useOptionalChain]: Change to an optional chain.
+warning[nursery/useOptionalChain]: Change to an optional chain.
   ┌─ complexLogicalAndCases.ts:2:1
   │
 2 │ foo && foo[bar as string] && foo[bar as string].baz;
@@ -31,7 +31,7 @@ Suggested fix: Change to an optional chain.
 ```
 
 ```
-warning[correctness/useOptionalChain]: Change to an optional chain.
+warning[nursery/useOptionalChain]: Change to an optional chain.
   ┌─ complexLogicalAndCases.ts:3:1
   │
 3 │ foo && foo[1 + 2] && foo[1 + 2].baz;
@@ -49,7 +49,7 @@ Suggested fix: Change to an optional chain.
 ```
 
 ```
-warning[correctness/useOptionalChain]: Change to an optional chain.
+warning[nursery/useOptionalChain]: Change to an optional chain.
   ┌─ complexLogicalAndCases.ts:4:1
   │
 4 │ foo && foo[typeof bar] && foo[typeof bar].baz;

diff --git a/...tness/useOptionalChain/logicalAndCases.js → ...rsery/useOptionalChain/logicalAndCases.js b/...tness/useOptionalChain/logicalAndCases.js → ...rsery/useOptionalChain/logicalAndCases.js