support for computed member expression

rome · Nov 9, 2022 · eced59e · eced59e
1 parent d2fbe92
commit eced59e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 246 deletions.
diff --git a/crates/rome_js_analyze/src/analyzers/a11y/use_valid_anchor.rs b/crates/rome_js_analyze/src/analyzers/a11y/use_valid_anchor.rs
@@ -312,7 +312,6 @@ fn is_invalid_anchor(anchor_attribute: &JsxAttribute) -> Option<UseValidAnchorSt
                 }
                 JsAnyExpression::ImportMeta(_)
                 | JsAnyExpression::JsClassExpression(_)
-                | JsAnyExpression::JsComputedMemberExpression(_)
                 | JsAnyExpression::JsImportCallExpression(_)
                 | JsAnyExpression::JsLogicalExpression(_)
                 | JsAnyExpression::JsObjectExpression(_)

diff --git a/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx b/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx
@@ -17,8 +17,9 @@
     <a href={`https://www.javascript.com`}/>
     <a href={somewhere}/>
     <a {...spread }/>
-    <a href={getFileUrl({ id: cExport.exportBinaryId })}>Download</a>
+    <a href={getFileUrl()}>Download</a>
     <a href={a ? b : c}>Download</a>
     <a href={1 + 2}>Download</a>
     <a href={await getLink()}>Download</a>
+    <a href={a["a"]}>Download</a>
 </>
diff --git a/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx.snap b/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx.snap
@@ -23,6 +23,11 @@ expression: useValidAnchor.jsx
     <a href={`https://www.javascript.com`}/>
     <a href={somewhere}/>
     <a {...spread }/>
+    <a href={getFileUrl()}>Download</a>
+    <a href={a ? b : c}>Download</a>
+    <a href={1 + 2}>Download</a>
+    <a href={await getLink()}>Download</a>
+    <a href={a["a"]}>Download</a>
 </>
 ```
 

diff --git a/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx.snap.new b/crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx.snap.new