Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 Formatter: Format jestEach template literals #3308

Closed
MichaReiser opened this issue Sep 30, 2022 · 4 comments · Fixed by #3582
Closed

📎 Formatter: Format jestEach template literals #3308

MichaReiser opened this issue Sep 30, 2022 · 4 comments · Fixed by #3582
Assignees
@denbezrukov
Labels
A-Formatter Area: formatter S-Planned Status: planned by the team, but not in the short term task A task, an action that needs to be performed

Comments

@MichaReiser
Copy link
Contributor

Description

See https://github.com/prettier/prettier/blob/d13feed42b6478710bebbcd3225ab6f203a914c1/src/language-js/print/template-literal.js#L114
@MichaReiser MichaReiser added task A task, an action that needs to be performed A-Formatter Area: formatter labels Sep 30, 2022
@MichaReiser MichaReiser mentioned this issue Oct 11, 2022
Closed
@github-actions
Copy link

This issue is stale because it has been open 14 days with no activity.

@denbezrukov
Copy link
Contributor

I'd like to try.

@ematipico ematipico changed the title 📎 Formater: Format jestEach template literals 📎 Formatter: Format jestEach template literals Oct 18, 2022
@github-actions github-actions bot removed the S-Stale label Oct 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

This issue is stale because it has been open 14 days with no activity.

@denbezrukov
Copy link
Contributor

I'm working on it.

@ematipico ematipico added S-Planned Status: planned by the team, but not in the short term and removed S-Stale labels Nov 2, 2022
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 8, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals rome#3308
9121f56
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 8, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals rome#3308
6d0a5e5
@denbezrukov denbezrukov mentioned this issue Nov 8, 2022
Merged
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 8, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals rome#3308
0dbece5
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 8, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals rome#3308
119ea23
@MichaReiser MichaReiser added this to the 10.1.0 milestone Nov 8, 2022
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 9, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals rome#3308
0bfbc30
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 9, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals rome#3308
4b329e9
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 9, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals rome#3308
9bab47f
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 9, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals rome#3308
adc43fc
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 14, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals rome#3308
30cb7b9
MichaReiser pushed a commit that referenced this issue Nov 14, 2022
@denbezrukov
feat(rome_js_formatter): jestEach template literals #3308 (#3582)
745bdaa 
Close #3308
@MichaReiser MichaReiser moved this to Done in Rome 2022 Nov 14, 2022
jeysal added a commit to jeysal/rometools that referenced this issue Nov 14, 2022
@jeysal
Merge remote-tracking branch 'upstream/main' into no-dupe-keys
1b0f6fa 
* upstream/main: (45 commits)
  website(docs): set `color-scheme` on the root element (rome#3721)
  feat(rome_analyze): add a warning for unused suppression comments (rome#3718)
  feat(rome_js_analyze): Implement prefer-numeric-literals lint (rome#3558)
  feat(rome_js_formatter): jestEach template literals rome#3308 (rome#3582)
  doc(website): Add context about Romes philosophy (rome#3714)
  fix(rome_js_formatter): Single-line comment below a JSX prop triggers… (rome#3641)
  test(rome_js_formatter): update prettier tests (rome#3684)
  fix(rome_js_parser): improve await handling in non-async context (rome#3573)
  fix(rome_js_parser): improve yield parsing in non generator function (rome#3622)
  More playground polish
  Fix backgrounds
  Fix height
  Align docs.rome.tools with rome.tools
  Reenable compression
  Add missing width
  website(docs): More playground IDE features (rome#3711)
  fix(rome_js_formatter): new expression attribute (rome#3686)
  docs(website): added checkbox to toggle linter in playground (rome#3699)
  website(docs): More website tweaks (rome#3707)
  website(docs): Add default layout property (rome#3705)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@denbezrukov denbezrukov

Labels
A-Formatter Area: formatter S-Planned Status: planned by the team, but not in the short term task A task, an action that needs to be performed
Projects
Rome 2022
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rome_js_formatter): jestEach template literals #3308 denbezrukov/tools
3 participants
@ematipico @MichaReiser @denbezrukov