Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 Trailing comma inside import #3600

Closed
1 task done
ritz078 opened this issue Nov 8, 2022 · 1 comment · Fixed by #3624
Closed
1 task done

🐛 Trailing comma inside import #3600

ritz078 opened this issue Nov 8, 2022 · 1 comment · Fixed by #3624
Assignees
@denbezrukov
Labels
A-Formatter Area: formatter Help wanted Help would be really appreciated L-JavaScript Langauge: JavaScript S-Bug: confirmed Status: report has been confirmed as a valid bug
Milestone
10.0.1

Comments

@ritz078
Copy link

ritz078 commented Nov 8, 2022 •
edited
Loading

Environment information

CLI:
  Version:              10.0.0
  Color support:        true

Platform:
  CPU Architecture:     aarch64
  OS:                   macos

Environment:
  ROME_LOG_DIR:         unset
  NO_COLOR:             unset
  TERM:                 "xterm-256color"

Rome Configuration:
  Status:               loaded
  Formatter disabled:   false
  Linter disabled:      true

Workspace:
  Open Documents:       0

Discovering running Rome servers...

Server:
  Status:               stopped

What happened?

Here is the code snippet: playground

Rome adds a trailing comma inside import and babel parser throws an error (Trailing comma is disallowed inside import(...) arguments) during compilation. This isn't a problem with prettier.

Expected result

const StandaloneBackendWASMModule = await import(
	/* webpackChunkName: "standalone" */ "./StandaloneBackendWASM"
);

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@ritz078 ritz078 added the S-To triage Status: user report of a possible bug that needs to be triaged label Nov 8, 2022
@MichaReiser MichaReiser added S-Bug: confirmed Status: report has been confirmed as a valid bug A-Formatter Area: formatter L-JavaScript Langauge: JavaScript Help wanted Help would be really appreciated and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Nov 9, 2022
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 9, 2022
@denbezrukov
fix(rome_js_formatter): Trailing comma inside import rome#3600
656dece
@denbezrukov
Copy link
Contributor

Could I fix it?

denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 9, 2022
@denbezrukov
fix(rome_js_formatter): Trailing comma inside import rome#3600
d79e707
@denbezrukov denbezrukov mentioned this issue Nov 9, 2022
Merged
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 9, 2022
@denbezrukov
fix(rome_js_formatter): Trailing comma inside import rome#3600
4a7954c
denbezrukov added a commit to denbezrukov/tools that referenced this issue Nov 9, 2022
@denbezrukov
fix(rome_js_formatter): Trailing comma inside import rome#3600
4e7cbcd
@leops leops added this to the 10.0.1 milestone Nov 9, 2022
MichaReiser pushed a commit that referenced this issue Nov 9, 2022
@denbezrukov
fix(rome_js_formatter): Trailing comma inside import #3600 (#3624)
b788d70 
Fix #3600
jeysal added a commit to jeysal/rometools that referenced this issue Nov 10, 2022
@jeysal
Merge remote-tracking branch 'upstream/main' into no-dupe-keys
62c5af4 
* upstream/main:
  fix(npm/js-api): Import type from @rometools/backend-jsonrpc (rome#3647)
  doc(npm/js-api): Add experimental warning to README
  fix(npm/js-api): Lazy load backend implementations (rome#3652)
  feat(rome_lsp): stop the daemon after the last client disconnects (rome#3643)
  fix(npm/js_api): Ensure JS API build contains `dist` folder (rome#3648)
  fix(rome_cli): ensures the service only connects to compatible versions (rome#3642)
  feat(playground): add settings button and group IR (rome#3559)
  release: v10.0.1 (rome#3649)
  fix(rome_js_analyze): False positives for interactive elements in `useKeyWithClickEvents` (rome#3644)
  fix(rome_js_semantic): support for object and array bindings when exporting (rome#3620)
  doc(editors): Clarify Rome discovery (rome#3639)
  fix(rome_js_analyze): improve the detection of `ReactDOM.render` calls in `noRenderReturnValue` (rome#3626)
  chore(npm): add license (rome#3629)
  Add rustdocs index
  Add environment
  Change rust docs to use Netlify
  fix(rome_js_analyze): useValidAnchor considering all possible expressions (rome#3599)
  fix(rome_js_formatter): Trailing comma inside import rome#3600 (rome#3624)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@denbezrukov denbezrukov

Labels
A-Formatter Area: formatter Help wanted Help would be really appreciated L-JavaScript Langauge: JavaScript S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
10.0.1
Development

Successfully merging a pull request may close this issue.

fix(rome_js_formatter): Trailing comma inside import #3600 denbezrukov/tools
4 participants
@MichaReiser @leops @ritz078 @denbezrukov