🐛 rule style/noNonNullAssertions emit incorrect code action

[ematipico]

Environment information

Rome v12

What happened?

The rule style/noNonNullAssertions emits an incorrect code action. In particular, its AST is wrong!

Given this code:

session!.hey

It seems to return a correct code:

session?.hey

Although, the AST is wrong:

CommitChange {
            parent_depth: 11,
            parent: Some(
                0: [email protected]
                  0: [email protected]
                    0: [email protected]
                      0: [email protected] "session" [] []
                  1: [email protected] "!" [] []
                ,
            ),
            parent_range: Some(
                (
                    23,
                    31,
                ),
            ),
            new_node_slot: 1,
            new_node: Some(
                Token(
                    [email protected] "?" [] [],
                ),
            ),
        },

Which is wrong and it results in an endless loop when calling rome check --apply-unsafe because there's always a TS_NON_NULL_ASSERTION_EXPRESSION.

The correct way is to return a new code, which is a JsStaticMemberExpression. Playground

Expected result

The rule to emit a correct AST and not result in an endless loop when calling rome check --apply-unsafe

Code of Conduct

• I agree to follow Rome's Code of Conduct

[ematipico]

@notmd cc you as you worked on the rule, in case you are interested at applying the fix