This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rslint_parser): Try Statement Facade #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
241373e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca1f7508.tools-8rn.pages.dev |
|
TODO: Change base branch after #1769 is merged. |
This was referenced Nov 11, 2021
ematipico
approved these changes
Nov 11, 2021
MichaReiser
force-pushed
the
feature/restructure-simple-statements
branch
from
216b8e2
to
5110b41
Compare
MichaReiser
force-pushed
the
feature/restructure-try-statement
branch
from
4143382
to
4af331e
Compare
Base automatically changed from
feature/restructure-simple-statements
to
main
November 11, 2021 14:14
Changes the structure and naming of the Try Stmt: * Split into `TryStatement` and `TryFinallyStatement` so that we can correctly model the optionality of the catch/finally clauses. * Rename `test` child to `body` * Rename `handler` to `catch_clause` * Rename `finalizer` to `finally_clause` to align with `catch_clause` * Extract the `JsCatchDeclaration` from the `JsCatchClause` to group the optional `(e)` * Extend the integration tests for try statement
* Rename `ThrowStmt` to `JsThrowStatement` * Rename `exception` field to `argument`
MichaReiser
force-pushed
the
feature/restructure-try-statement
branch
from
4af331e
to
241373e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the structure and naming of the Try and Throw statements
TryStatementandTryFinallyStatementso that we can correctly model the optionality of the catch/finally clauses.testchild tobodyhandlertocatch_clausefinalizertofinally_clauseto align withcatch_clauseJsCatchDeclarationfrom theJsCatchClauseto group the optional(e)JsThrowStatementexceptionchild toargumentBased on #1769 and part of #1725
Test Plan
Verified that coverage doesn't change. Added new integration tests for try statement.