This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rslint_parser): Update while loops to match new AST Facade #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename to `JsDoWhileStatement` * Inline condition * rename `cons` to `body` * rename `condition` to `test`
Changes the name and structure of the While statement facade * Rename from `WhileStmt` to `JsWhileStatement` * Rename `cons` to `body` * Inline the condition
Changes the name and structure of the Continue and Break statement facades * Rename from `ContinueStmt` and `BreakStmt` to `JsContinueStatement` and `JsBreakStatement` * Inline the identifier (It's not a normal "variable" reference but a label reference)
Deploying with
|
| Latest commit: |
cad9c18
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a2859dbb.tools-8rn.pages.dev |
MichaReiser
commented
Nov 12, 2021
| fn to_format_element(&self, formatter: &Formatter) -> FormatResult<FormatElement> { | ||
| let break_element = formatter.format_token(&self.break_token()?)?; | ||
| let ident = if let Some(ident_token) = self.ident_token() { | ||
| group_elements(format_elements
ematipico
approved these changes
Nov 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the js grammar to match our new AST facade as defined in #1725 (and proposed in #1719)
ContinueStatementContinueStmttoJsContinueStatementBreakStatementBreakStmttoJsBreakStatementWhileStatementWhileStmttoJsWhileStatementconstobodyconditiontotestDoWhileStatementJsDoWhileStatementconstobodyconditiontotestPart of #1725
Test Plan
Verified the output in the updated
rastfiles to correctly reflect the parsing changes and verified that the coverage isn't changing.