-
Notifications
You must be signed in to change notification settings - Fork 660
Conversation
Deploying with Cloudflare Pages
|
Test262 coverage results |
Test262 coverage results
|
Should we add some summary text to the coverage results (with some emoji?) so that it's immediately clear if everything is good or if it requires attention? |
Feel free to suggest what you want. At the moment if some number changes, they are highlighted in bold. |
c536404
to
b5523b6
Compare
898be1e
to
1291de1
Compare
466cf98
to
2a36ec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just make sure to strip out the error changes.
Test262 comparison coverage results on ubuntu-latest
|
Test262 comparison coverage results on windows-latest
|
Test262 comparison coverage results on macos-latest| Test result | |
@@ -67,10 +64,55 @@ jobs: | |||
uses: Swatinem/rust-cache@v1 | |||
- name: Run Test262 suite on main branch | |||
continue-on-error: true | |||
run: cargo xtask coverage --json | |||
run: cargo xtask coverage --json > base_results.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that it now takes quite a while until the results show up on the PR because the coverage command must run twice. Do you think there's a way to publish the result for "main" and store it (e.g. using the commit number in the name) whenever a commit gets merged so that we may just retrieve it (and only run xtask coverage
in the case it's missing for whatever reason)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is something I discussed with the others during the standup.
Boa uses Github pages to store the results.
Cloudflare doesn't have a storage service yet. Github actions artifacts are not readable across workflows. Maybe, for now, we should use Github pages
Summary
This PR implements workflow actions to tell github-bot to run the coverage on
main
branch and execute the comparison between the coverage results of this PR and the coverage results onmain
.This the an example of comment in case there's an increase of coverage:
main
countAnd this is an example in case the coverage decreases:
main
countAt the moment the command is failing because I changed the logic of the command when using
--json
as suggested in a previous PR.Test Plan
I run the commands manually against this PR and the
main
branch and made sure it works. Also, pasted the results emitted locally.