This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feature(formatter): JSX Spread Attribute #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasLYang
changed the title
Parser conformance results on ubuntu-latestjs/262
jsx/babel
ts/babel
ts/microsoft
|
Deploying with
|
| Latest commit: |
3177944
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6c5e003.tools-8rn.pages.dev |
NicholasLYang
force-pushed
the
feature/jsx-spread-attribute
branch
from
1bf9b25
to
b540af8
Compare
|
The JS formatting fails because we need to update the action to use the latest version of the formatter. |
Or we could avoid updating the JSX files inside the playground. Unfortunately this is the only caveat of the action, where we want to dog food the npm installation. Could update the test plan template please? |
|
Okay reverted the jsx changes. Perhaps we need a CI workflow that builds a nightly Rome CI workflow haha. |
ematipico
suggested changes
Apr 26, 2022
ematipico
approved these changes
Apr 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2278
Test Plan
Added some tests for spread attribute formatting. Playground link