This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): Format throw and return argument
#2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
feat/format-throw-return
branch
from
ce57ad2
to
50a1108
Compare
Deploying with
|
| Latest commit: |
3940b57
|
| Status: | ⚡️ Build in progress... |
ematipico
approved these changes
Aug 2, 2022
crates/rome_js_formatter/src/js/expressions/parenthesized_expression.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_formatter/src/js/expressions/parenthesized_expression.rs
Outdated
Show resolved
Hide resolved
MichaReiser
force-pushed
the
feat/format-throw-return
branch
from
50a1108
to
afeef35
Compare
This PR ensures that `throw` and `return` add parentheses around the argument for binary like expressions, sequence expressions, and if the argument has any leading comments. ## Testing I manually reviewed all snapshot cases. The differences to prettier are around * formatting of binary like expressions -> separate PR * when to add or omit parentheses -> not part of this PR * comments -> requires the comments refactoring.
MichaReiser
force-pushed
the
feat/format-throw-return
branch
from
afeef35
to
3940b57
Compare
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
throwandreturnadd parentheses around the argument for binary like expressions, sequence expressions and if the argument has any leading comments.Testing
I manually reviewed all snapshot cases. The differences to prettier are around
File Based Average Prettier Similarity: 77.98% -> 78.02%
Line Based Average Prettier Similarity: 73.23% -> 73.20%
The main reason why line based regresses is that the parenthesized / comments issues tend to spawn over multiple lines. However, these must be addressed as part of their own PR as they require significant architectural changes.