This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_formatter): Parenthesize assignments #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements the addition and removal of parentheses around assignments. There are only very few cases where parentheses are necessary around assignments. Mainly: * `TsTypeAssertionAssignment` * `TsAsAssignment` * identifiers named `async` in for loops ## Tests I added unit tests to the cases where parentheses are necessary
Deploying with
|
| Latest commit: |
c2754ae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8ba526b.tools-8rn.pages.dev |
| Branch Preview URL: | https://feat-assignment-parentheses.tools-8rn.pages.dev |
ematipico
approved these changes
Aug 19, 2022
IWANABETHATGUY
pushed a commit
to IWANABETHATGUY/tools
that referenced
this pull request
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the addition and removal of parentheses around assignments.
There are only very few cases where parentheses are necessary around assignments. Mainly:
TsTypeAssertionAssignmentTsAsAssignmentasyncin for loopsThis is why most of this PR is just boilerplate.
Average compatibility: 81.64 -> 81.73
Compatible lines: 78.42 -> 78.48
Tests
I added unit tests to the cases where parentheses are necessary