This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 660
fix(rome_js_parser): Adding syntax error for new A?.b() #3118
Merged
MichaReiser
merged 13 commits into
rome:main
from
IWANABETHATGUY:fix/optional_chaining_new_expr
Sep 21, 2022
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ff129eb
fix: 🐛 optional chaining
IWANABETHATGUY f14b4f5
test: 💍 udpate snapshot
IWANABETHATGUY f5b2053
test: 💍 update snapshot
IWANABETHATGUY 5d3a82c
chore: 🤖 update snapshot
IWANABETHATGUY 1e2636c
fix: 🐛 align to ts
IWANABETHATGUY 6177afc
chore: 🤖 lint and format
IWANABETHATGUY 2f90173
chore: 🤖 disabled invalid code action case
IWANABETHATGUY 6fc2989
fix: 🐛 remove extra assertion_line
IWANABETHATGUY 7c7017e
chore: 🤖 add extra tracked comment
IWANABETHATGUY 2554732
chore: 🤖 move inline test case
IWANABETHATGUY a306c8f
chore: 🤖 update parser
IWANABETHATGUY fb8b5f7
chore: 🤖 fmt
IWANABETHATGUY 7278b0b
chore: 🤖 update parser test
IWANABETHATGUY File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the error checking here because I don't want to clone the
lhs.text(p)
. If put this branch here, https://github.com/rome/tools/pull/3118/files#diff-1ca6d1ff770e933910c550807255d1bf03cdebbf60bf469579b528c0c28c1537R797, you can't return a&str
oflhs.text(p)
because lhs is moved vialhs.undo_completion(p)