Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): useCamelCase accepts function when they are used in new or exported #3210

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Sep 13, 2022

Summary

This PR add support for non camel case function when:
1 - They are used inside a new expression;
2 - They are exported.

Test Plan

> cargo test -p rome_js_analyze -- camel_case

@xunilrj xunilrj requested a review from leops as a code owner September 13, 2022 12:44
@xunilrj xunilrj temporarily deployed to netlify-playground September 13, 2022 12:44 Inactive
@github-actions
Copy link

github-actions bot commented Sep 13, 2022

@xunilrj xunilrj temporarily deployed to netlify-playground September 13, 2022 13:58 Inactive
@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for rometools ready!

Name Link
🔨 Latest commit 4dcc60b
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/63207b20813e050008dbc4af
😎 Deploy Preview https://deploy-preview-3210--rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit 72024f0
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/6320b07f91f8f200093298be

@xunilrj xunilrj force-pushed the feature/accept-camel-case-when-new-or-export branch from 4e0130d to 2d31bb9 Compare September 13, 2022 16:20
@xunilrj xunilrj temporarily deployed to netlify-playground September 13, 2022 16:20 Inactive
@xunilrj xunilrj force-pushed the feature/accept-camel-case-when-new-or-export branch from 2d31bb9 to 72024f0 Compare September 13, 2022 16:31
@xunilrj xunilrj temporarily deployed to netlify-playground September 13, 2022 16:32 Inactive
@ematipico ematipico merged commit 08a46de into main Sep 14, 2022
@ematipico ematipico deleted the feature/accept-camel-case-when-new-or-export branch September 14, 2022 08:03
@xunilrj xunilrj added A-Linter Area: linter L-JavaScript Langauge: JavaScript labels Sep 14, 2022
@xunilrj xunilrj added this to the 0.10.0 milestone Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter L-JavaScript Langauge: JavaScript
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants