Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

refactor(rome_formatter): Comments all in one #3212

Closed
wants to merge 45 commits into from

Conversation

MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Sep 13, 2022

Summary

A messy PR at this point addressing the #2768

Test Plan

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit eb5aea6
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/6322f584aa6ec6000807dc72

@MichaReiser MichaReiser temporarily deployed to netlify-playground September 13, 2022 14:31 Inactive
@MichaReiser MichaReiser changed the title Refactor/comments v100 refactor(rome_formatter): Comments Sep 13, 2022
@github-actions
Copy link

github-actions bot commented Sep 13, 2022

@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44939 44939 0
Failed 940 940 0
Panics 0 0 0
Coverage 97.95% 97.95% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1621 1621 0
Failed 4325 4325 0
Panics 0 0 0
Coverage 27.26% 27.26% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12395 12395 0
Failed 3862 3862 0
Panics 0 0 0
Coverage 76.24% 76.24% 0.00%

@MichaReiser MichaReiser temporarily deployed to netlify-playground September 13, 2022 16:11 Inactive
@MichaReiser MichaReiser temporarily deployed to netlify-playground September 15, 2022 06:08 Inactive
@MichaReiser MichaReiser temporarily deployed to netlify-playground September 15, 2022 06:59 Inactive
@MichaReiser MichaReiser temporarily deployed to netlify-playground September 15, 2022 07:49 Inactive
@MichaReiser MichaReiser temporarily deployed to netlify-playground September 15, 2022 07:51 Inactive
@MichaReiser MichaReiser temporarily deployed to netlify-playground September 15, 2022 08:04 Inactive
@MichaReiser MichaReiser temporarily deployed to netlify-playground September 15, 2022 09:25 Inactive
@MichaReiser MichaReiser changed the title refactor(rome_formatter): Comments refactor(rome_formatter): Comments all in one Sep 15, 2022
@MichaReiser MichaReiser temporarily deployed to netlify-playground September 15, 2022 09:51 Inactive
@MichaReiser
Copy link
Contributor Author

Closing in favour of #3227

@MichaReiser MichaReiser deleted the refactor/comments-v100 branch November 23, 2022 07:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant