This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_formatter): Part 3: Delete FormatElement::Comment
#3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
changed the title
FormatElement::CommentFormatElement::Comment
ematipico
approved these changes
Sep 16, 2022
MichaReiser
force-pushed
the
feat/comments-api
branch
from
ac99767
to
3abdba9
Compare
This PR removes the `FormatElement::Comment` element. It was used to this point because the `group` builder had to move `comments` outside of the start/end of the group. No such inspection is necessary after the refactor which is why the element can be deleted.
MichaReiser
force-pushed
the
feat/comments-api
branch
from
3abdba9
to
df087ed
Compare
MichaReiser
force-pushed
the
refactor/comment-format-element
branch
from
7bcef41
to
7cbec6f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the comments refactoring #3227.
This PR removes the
FormatElement::Commentelement. It was used to this point because thegroupbuilder had to movecommentsoutside of the start/end of the group.No such inspection is necessary after the refactor which is why the element can be deleted.