This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_formatter): Part 4: Move verbatim formatting to rome_formatter
#3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
changed the title
rome_formatterrome_formatter
This PR moves the logic for formatting a node as `verbatim` to `rome_formatter` as it isn't JS specific
MichaReiser
force-pushed
the
refactor/comment-format-element
branch
from
7bcef41
to
7cbec6f
Compare
MichaReiser
force-pushed
the
refactor/move-verbatim-to-formatter
branch
from
36e4367
to
be56d34
Compare
ematipico
approved these changes
Sep 16, 2022
Base automatically changed from
refactor/comment-format-element
to
refactor/comments
September 19, 2022 14:50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the comments refactoring #3227.
This PR moves the logic for formatting a node as
verbatimtorome_formatteras it isn't JS specificIt also deletes some of the no longer needed builders like
format_inserted,format_parenthesized, andformat_delimited(A PR with the replacement will follow soon).