This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_formatter): Part 7: Use comments API in JS node formatters #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
refactor/js-comments-formatting
branch
from
fdaf608
to
ef9db3e
Compare
MichaReiser
force-pushed
the
refactor/js-syntax-comments
branch
from
5839e85
to
e1b3883
Compare
MichaReiser
force-pushed
the
refactor/js-syntax-comments
branch
from
a304196
to
c2038ef
Compare
MichaReiser
force-pushed
the
refactor/js-comments-formatting
branch
from
37f0c09
to
1837c70
Compare
MichaReiser
force-pushed
the
refactor/js-syntax-comments
branch
from
c2038ef
to
9f33f98
Compare
Base automatically changed from
refactor/js-comments-formatting
to
refactor/comments
September 20, 2022 16:28
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the comments refactor #3227.
It is (almost) the final piece. It makes the necessary changes to the various formatters for all the JS syntaxes to use the new API, and correctly place comments. It has sometimes been necessary to fix small formatting issues of individual nodes to match Prettier's output.
Test Plan
Average compatibility: 86.15 -> 88.36
Compatible lines: 84.93 -> 89.34